Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.4.3 #339

Merged
merged 8 commits into from
Jun 3, 2024
Merged

V1.4.3 #339

merged 8 commits into from
Jun 3, 2024

Conversation

t-young31
Copy link
Member

Anything else you want to include in this release @shoubhikraj ?

t-young31 and others added 7 commits March 3, 2024 14:41
* Improve string parsing in reaction.delta method

- Improved string parsing that all synonyms for double dagger can be used
- Added tests that determine if right energy is chosen

* Template (#326)

* Added changelog

---------

Co-authored-by: Tom Young <[email protected]>
* fix qrc solvent

* Update pytest_cov.yml
* Update "atoms_to_xyz_file()" in "input_output.py"

Added explicit space to xyz coordinates to account for occasional cases where there is no space printed between two numbers, for example, `H    13.56100 -35.93700-100.99000`, and thus the printed xyz file became invalid.

* update changelog for `atoms_to_xyz_file` function fix

* test for `atoms_to_xyz_file` function fix
* store history with pickle

* update to allow save and reload

* update interface

* make optimiers history more flexible

* updates

* test fix

* partial fixes for test

* updates for bracket methods

* fix tests

* fix tests

* partial fixes

* disallow saving to reloaded optimiser history

* fix nwchem test

* fix tests

* add tests

* add tests

* fix test

* coverage update 1

* coverage update 1

* add tests

* bug fix

* update coverage

* coverage update

* refactor micro iters for ieip

* minor change

* fix tests

* PR suggestions 1

* PR suggestions 2

* PR suggestions 3

* revert zip extension for trajectory

* pr suggestion 2

* doc update

* lint fix

* lint fix

* lint fix
* initial update

* refactor hessian update - unfinished

* refactor hessian update - unfinished

* refactor hessian update

* fix test

* update pytest

* coverage update

* pr update

* pr update 2

* dhs bug fix

* update changelog
* recursion error bugfix

* add steepest descent step

* add test

* add test

* add test

* add damped step

* add logging

* add tests

* pr suggestion
@t-young31 t-young31 linked an issue May 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 99.44290% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 97.41%. Comparing base (034743c) to head (c3359f5).

Files Patch % Lines
autode/bracket/ieip.py 91.42% 3 Missing ⚠️
autode/opt/optimisers/utils.py 98.59% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   97.44%   97.41%   -0.03%     
==========================================
  Files         209      202       -7     
  Lines       23747    23210     -537     
==========================================
- Hits        23141    22611     -530     
+ Misses        606      599       -7     
Flag Coverage Δ
unittests 97.41% <99.44%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shoubhikraj
Copy link
Collaborator

@t-young31 I was thinking of fixing some part of #301 but it will take me a few days to write the PR.

* add step size adjustment

* cubic polyfit

* update

* update

* update

* replace barrier check

* small updates

* small update

* fix peak detection

* swtiching step sizes

* remove step adjust and refactor

* fix tests

* update tests

* add test

* unfinished update

* refactor polynomial code

* refactor polynomial code 2

* update changelog
@shoubhikraj
Copy link
Collaborator

@t-young31 Feel free to merge this when you want, I don't have anything more to add.

@t-young31 t-young31 merged commit 2f3af32 into master Jun 3, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solvent not being added with G09 for TS quick-reaction coordinate
4 participants